Fix preview feature for vim without patch-8.1.1517 #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simnalamburt
force-pushed
the
fix-preview
branch
from
c828d8e to
39a0840
Compare
|
Is this fixing #712 ? |
Unfortunately it seems to be unrelated |
simnalamburt
force-pushed
the
fix-preview
branch
from
322dad2 to
3a4ca4f
Compare
|
I've rebased it! |
|
Thank you. Could you please explain how to reproduce your issue and repro steps. |
|
If your vim doesn’t have floating window feature, vim-lsp feature-detects
it and automatically avoid using it. But at there, vim-lsp ignore the
result of feature-detection and just use the “g:lsp_preview_float”. And it
behaves strange because of that.
If you try to use vim-lsp in vim without floating windows feature and open
preview windows multiple times in different places, internel state of
vim-lsp become inconsistent and multiple preview window showed up. And then
those preview windows won’t be closed with `:pclose`.
2020년 3월 1일 (일) 20:27, mattn <[email protected]>님이 작성:
… Thank you. Could you please explain how to reproduce your issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#728?email_source=notifications&email_token=ABB235JA3BEBAZF5ZBLYDBDRFJBBBA5CNFSM4K2OMSZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENM4OIY#issuecomment-593086243>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABB235LVYA5A4OS5R7IB2G3RFJBBBANCNFSM4K2OMSZQ>
.
|
Even if `g:lsp_preview_float` is true, vim-lsp should call `:pclose` if `s:use_preview` is true.
simnalamburt
force-pushed
the
fix-preview
branch
from
3a4ca4f to
3f5e386
Compare
|
@mattn How to reproduce:
|
|
Thank you. I'll look this in later. |
Ah, I understand what this change fix now. |
|
Thank you. |
simnalamburt
added a commit
to simnalamburt/.dotfiles
that referenced
this pull request
Mar 3, 2020
prabirshrestha/vim-lsp#728 has been merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if
g:lsp_preview_floatis true, vim-lsp should call:pcloseifs:use_vim_popupis false.